David Coallier [2009-04-03 14:27 UTC] Would it be possible to put links to the sources without having to download the package please? After downloading the package I get:
$ tar -xzvf Event_Dispatcher2-0.5.10.tgz
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Archive contains obsolescent base-64 headers
tar: Error exit delayed from previous errors
I'd also consider changing the license as the PHP License is not a license we recommend for our developers. You may want to go for something a bit more flexible and open.
Matthew Weier O'Phinney [2009-04-03 19:48 UTC] I second David's request; I'd like to be able to browse the source without needing to download it.
Also, could you give a summary of any architectural changes you're making in porting from PHP4 to PHP5? It would make it easier to know what specific changes to review.
Till Klampaeckel [2009-04-04 12:56 UTC] I've looked at the code:
http://dev.sharedlog.com/svn/trunk/Event/
A few pointers first off:
1) The license on the proposal says PHP License, but in the code it's the BSD License. Which one is it? :)
2) phpcs (PHP_CodeSniffer) should be run on the code (to conform to basic PEAR CS).
3) require_once inside class-code is not a good idea, especially when you can override the class name? Use class_exists() and include_once instead, etc..
4) Can you integrate SimpleTest using an AllTests.php file?
|
