Comments for "Math_Polynomial (Re-proposal)"

» Submit Your Comment
Comments are only accepted during the "Proposal" phase. This proposal is currently in the "Finished" phase.
» Comments
  • Arnaud Limbourg  [2005-12-16 06:46 UTC]

    You did a great job ! (from a non-math pov it looks great :)
  • bertrand Gugger  [2005-12-16 16:19 UTC]

    Looks good ...
    * you must require 'Math/Polynomial.php'; not 'Polynomial.php', same for the other files and test.
    * perhaps let the possibility to the user to define MATH_POLYNOMIAL_ROUND_BOUNDARY (if (!defined(...))) ?
    * please, don't return PEAR::raiseError() in a method intended to return a reference, it breaks php5.
    * same for return new class(), you must use an intermediate variable.
  • Matthew Fonda  [2005-12-19 07:43 UTC]

    I would still like to see a separate Math_Derivative package to handle all derivatives, not just polynomials, but I suppose right now that isn't too important, just something to think about for the future.

    -- Matthew
  • Joshua Eichorn  [2006-01-06 19:45 UTC]

    Looks good
  • Jesus M. Castagnetto  [2006-01-09 14:25 UTC]

    The code looks good to me. Separating the types from the operations makes it easier to read and understand.

    I don't see a problem with this proposal, it is clear, well organized and can easily be develop to suppport more operations, etc.

    I'd say, go for it, you got my vote.