Vote Details for "Services_OpenSearch" by arpad

» Details
  • Voter: Arpad Ray 
  • Vote: +1 (conditional)
  • Reviews: Cursory source review
» Comment
Looks good to me with a couple of minor modifications:

The constants you define should be prefixed with the name of the package, eg. SERVICES_OPENSEARCH_VERSION.

I think it would also be best to set user_agent on use and restore it afterwards, so there's no side-effect.