Vote Details for "File_Sitemap" by gauthierm

» Details
  • Voter: Michael Gauthier 
  • Vote: +1 (not conditional)
  • Reviews: Cursory source review
» Comment
What till said. Additionally:

1. Specify public scope for methods File_SiteMap::__construct() and File_SiteMap::add()

2. Use single or double quotes consistently. I prefer single quotes unless escaping is required.

3. Use class constants instead of define statements for error codes. For example, use 'const ERROR_FOO = 1' in File_SiteMap so your error code is File_SiteMap::ERROR_FOO instead of FILE_SITEMAP_FOO_ERROR.

4. For mixed type arguments, you should specify what types are accepted in the parameter description. File_SiteMap_Index::add() comes to mind.