Comments for "File_Sitemap"

» Submit Your Comment
Comments are only accepted during the "Proposal" phase. This proposal is currently in the "Finished" phase.
» Comments
  • Philippe Jausions  [2008-04-26 16:42 UTC]

    Quick review:

    - The @license is not in sync with the license blurb in file docblock.
    - Don't use PHP4-style constructors, use PHP5's __construct() instead
    - You have some typos in the parseURL method in the $url array.
    - I'm not really seeing the need to double query the notify URL couldn't errors be handled in one pass only?
    - the test() method @return void while it actually @return boolean
    - There are trailing empty lines after the last closing ?> in the files