Comments for "OpenID-rejected"

» Submit Your Comment
Comments are only accepted during the "Proposal" phase. This proposal is currently in the "Finished" phase.
» Comments

  • Demian Turner  [2006-01-24 15:25 UTC]

    Hey JanRain,

    Nice package, much needed by the PHP community. Good work also on commenting and coding style. After a quick glance I can see a few very small issues:

    - please use require_once "Auth/OpenID/OIDUtil.php"; instead of require_once("Auth/OpenID/OIDUtil.php");
    - please use package namespaced constants instead of globals, ie Auth_OpenID_SUCCESS instead of $Auth_OpenID_SUCCESS = 'success';
    - avoid the use of globals whenever possible, security risk and bad programming style
    - use PEAR errors instead of trigger_error("blah")
    - perhaps consider using HTTP_Request for your fetcher stuff to avoid unnecessary code

    cheers

    Demian