Greg Beaver [2007-03-14 05:26 UTC] Hi Greg, looks interesting.
Could you provide source files in .phps format, or phpDocumentor-generated output with --sourcecode=on so we can see the source without having to download/unzip/open with editor?
Also, you should provide a direct link to the WiKID documentation as an ancillary link.
Greg Haygood [2007-03-15 03:00 UTC] I've added links to these various docs. Let me know if you need more, or if I should do anything differently. Thanks!
Greg Beaver [2007-03-15 03:14 UTC] Thanks Greg.
A few comments:
1) there seems to be a problem with the generated documentation, only the class docs are available. This is FYI, I can understand it isn't needed if you have the .phps
2) The PEAR manual at pear.php.net is egregiously out of date. All new submissions to PEAR must be E_STRICT compliant. This means you must depend on PHP 5.0.0 or newer, and can't use PEAR_Error, or PEAR. Instead, use PEAR_Exception. Relevant documentation is at http://pear.php.net/pepr/pepr-proposal-show.php?id=419 (It's not your fault you didn't know this, I just spent 10 minutes trying to find it in the manual and failed).
Your coding style is very clean and easy to read.
You need to add a dependency on the openssl extension to the list of dependencies and to package.xml on release.
Greg Haygood [2007-03-17 04:38 UTC] Thanks for all the tips. I've updated the package accordingly (I think!). Let me know if it needs anything else.
|
