Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.16.14

Bug #567 LiveUser::init useless code present
Submitted: 2004-01-13 19:13 UTC
From: jmikola at burgiss dot com Assigned: lsmith
Status: Closed Package: LiveUser
PHP Version: Irrelevant OS: ANY
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 42 - 40 = ?

 
 [2004-01-13 19:13 UTC] jmikola at burgiss dot com
Description: ------------ towards the end of the function: if (is_object($this->_auth)) { return true; } elseif (empty($this->_auth->handle)) { return false; } else { $this->_error = true; return PEAR::raiseError(null, LIVEUSER_AUTH_NOTFOUND, null, E_USER_WARNING, "Auth object not found in LiveUser::init()", 'LiveUser', true); } now, assuming the first condition fails, and $_auth is not an object, what chance is there that the handle variable within the hypothetical $_auth object is anything but empty? i can't think of a case where the last else pertaining to error-raising would ever be executed.

Comments

 [2004-01-25 13:49 UTC] lsmith
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better.