| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.16.14 |
| Bug #567 | LiveUser::init useless code present | ||
|---|---|---|---|
| Submitted: | 2004-01-13 19:13 UTC | ||
| From: | jmikola at burgiss dot com | Assigned: | lsmith |
| Status: | Closed | Package: | LiveUser |
| PHP Version: | Irrelevant | OS: | ANY |
| Roadmaps: | (Not assigned) | ||
[2004-01-13 19:13 UTC] jmikola at burgiss dot com
Description:
------------
towards the end of the function:
if (is_object($this->_auth)) {
return true;
} elseif (empty($this->_auth->handle)) {
return false;
} else {
$this->_error = true;
return PEAR::raiseError(null, LIVEUSER_AUTH_NOTFOUND, null, E_USER_WARNING,
"Auth object not found in LiveUser::init()", 'LiveUser', true);
}
now, assuming the first condition fails, and $_auth is not an object, what chance is there that the handle variable within the hypothetical $_auth object is anything but empty? i can't think of a case where the last else pertaining to error-raising would ever be executed.
Comments
[2004-01-25 13:49 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!