| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 3.7.2 |
| Bug #16563 | Check file extensions problem in phpcs-svn-pre-commit | ||
|---|---|---|---|
| Submitted: | 2009-09-02 16:31 UTC | ||
| From: | et3w503 | Assigned: | squiz |
| Status: | Closed | Package: | PHP_CodeSniffer (version 1.2.0) |
| PHP Version: | 5.1.6 | OS: | linux |
| Roadmaps: | (Not assigned) | ||
[2009-09-02 16:31 UTC] et3w503
(Kaijung Chen)
Description:
------------
phpcs-svn-pre-commit
http://svn.php.net/viewvc/pear/packages/PHP_CodeSniffer/trunk/scripts/phpcs-svn-pre-commit?revision=287629&view=markup
line 144
$extension = array_pop($fileParts);
If there are spaces in $extension, script will skip the processFile step.
For example, extension could be "php ".
It's better , if script could trim $extension.
$extension = trim(array_pop($fileParts));
Comments
[2009-09-08 08:03 UTC] squiz
(Greg Sherwood)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: squiz
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.
I can't replicate a file path with spaces, but the change doesn't break anything so I made it anyway. Thanks for the patch.