Description: ------------ replaceChildren() used by flexy:replace and flexy:content in the file CustomFlexyAttributes.php doesn't handle values like "object.var" or values with a modifier like ":h" correctly. I've posted this alredy as #14034 but since I attached a patch to the post before confirming my mail address, it seems now impossible to make the report public. BTS complains "Unknown salt"... Test script: --------------- test test Expected result: ---------------- var;?> object->var);?> Actual result: -------------- plugin("h}",$t->{var);?> <?php echo htmlspecialchars($t->{object->var});?>

Hmm, I should have let HTML_Template_Flexy_Token_Method::setValue() to parse method arguments and modifiers?

Here's the mutex patch that parses method inside setValue().

The patches had problem handling "method(#with colon: inside#)". Below is the fix for replacechildren-another.diff in case someone else is using it :) PATCH: --- pear/HTML/Template/Flexy/Token/Method.php +++ pear/HTML/Template/Flexy/Token/Method.php @@ -70,7 +70,8 @@ if (!is_array($value)) { $value = $this->parseAndSetIf($value); $modifier = strrpos($value,':'); - if ($modifier !== false) { + $parenClose = strrpos($value,')'); + if ($modifier !== false && ($parenClose === false || $parenClose < $modifier)) { $this->modifier = substr($value,$modifier+1); $value = substr($value,0,$modifier); } else TEST: EXPECTED: ACTUAL: