Vote Details for "Validate_IR" by jespino
| » Details |
|---|
|
| » Comment |
|
You haven't fixed the problems that Daniel O'Connor has notified, fix thats problems and you get my +1 vote. You can fix that in your tar.gz file published in the proposal url (the link is not correct, because you link .tgz and the file is .tar.gz), o you can fix this in the github repository, but fix the problems anywhere. Problems: * Mix of whitespaces and tab characters in the indentation. (Review the code with PHP_CodeSniffer, or fix the problems with whitespaces manually) Thats not critical, but is a good practice. * package.xml not exists. |