» Details |
---|
|
» Comment |
If it makes sense in your opinion, you might want to use phpDocumentor compatible comments for the constants to get API docs for them: // Indicates text type ham define("TEXT_BAYES_POSITIVE", 1001); (Justin might also add that you should use single quotes [not only here]) Some CS issues: - no space before the '(': public function __construct ($storage_module, $storage_configuration) // no space before the '(' - wired indentation, e.g. here: case TEXT_BAYES_POSITIVE: $token['positive_count'] = (int)$token['positive_count'] + 1; break; - missing spaces: for ($i=1;$i<=floor($freedom / 2);$i++) { Apart from these minor issues: a very nice package! |