Vote Details for "PagamentoCerto" by till

» Details
Voter: Till Klampaeckel [Wishlist] Vote: +1 (not conditional) Reviews: Deep source review
» Comment
Sorry that this took a while, the holidays got in the way. ;-) Anyway, extremely clean code, very well done. I second David -- I don't know much about this payment processor either. While I see the advantage of putting all Exceptions into the same file, I also think this breaks the class<->file layout, so I'm torn on that. Maybe the PEAR overlords can comment if this is "allowed". I have some minor edits, so I forked your repo on Github -- have a look, the changes are not conditional, just food for thought! <http://github.com/till/pagamentocerto/commit/75bc90c5c35bae9ea09edabfe1a21ac0c742aeb6>