Vote Details for "XML_RPC2 (reproposal)" by mansion

» Details
  • Voter: Bertrand Mansion 
  • Vote: +1 (not conditional)
  • Reviews: Deep source review
» Comment
XML_RPC2_Backend_Php_Response::encode()
XML_RPC2_Backend_Php_Response::encodeFault()
Please get rid of short php tags (<?=) which might not be supported by everyone. Also, it might be cleaner to get rid of ob_ functions in general.

Please implement a new HTTPRequest object that does not depend on cURL.

Getting rid of {{ and }} stuff in your comments might make your code easier to read, at least for non-vim users... But that's up to you.

Try to always put the { below the method name. You forgot to do so in a few places.

Thanks, the rest of your code is ok for me.