[2004-02-18 21:02 UTC] Basically I like the package, just two small things:
1. Some methods in DataGriColumn.php need docs
2. Why is it called HTML_DataGrid when it build Excel, XML, ... shouldn't it be called Structures_DataGrid?
3. Follow the naming conventions:
HTML/DataGrid/Column.php should contain HTML_DataGrid_Column class.
4. In your XML renderer you should use XML_Util to create the tags or replace XML entities yourself... If you put an & in a cell your XML will not be wellformed...
Just my 2 cts.
Stephan
[2004-02-19 09:43 UTC] Why not call parent::HTML_DataGridCore() in HTML_DataGrid_Renderer?
I first was thinking you were cheating multiple inheritance in HTML_DataGrid :-)
Mike
|
