Comments for "Services_Amazon"

» Submit Your Comment
Comments are only accepted during the "Proposal" phase. This proposal is currently in the "Finished" phase.
» Comments
  • Aidan Lister  [2004-07-28 11:26 UTC]

    What's the MIT license?

    Please check the documentation regarding suitable licenses.

    Here is some superficial stuff:
    We'd prefer you used // instead of /* for inline comments.
    I don't think you need a full example for each method.

    I think it's a pretty nice package, well done.
  • John Downey  [2004-07-28 11:39 UTC]

    Aidan, thanks for the comment. The I have read the documentation regarding licensing and it says that new license may be added on a case by case basis. I much prefer using the MIT License (http://www.opensource.org/licenses/mit-license.php) and see no real reason PEAR does not already allow it. Though I would be willing to change the licensing to a BSD-like license if needed. As for comments I was to understand that /* */ and // didn't matter so long as you didn't use #. I went ahead and changed it though. As for the full examples, maybe I just like to over document :)
  • John Downey  [2004-08-02 05:30 UTC]

    Just to clearify, I believe the MIT License qualifies as a BSD-style license in many respects, and the manual clearly allows BSD-style licenses. The only difference between the BSD license and the MIT license is the non-edorsement clause that is in the BSD license, as stated on http://www.opensource.org/licenses/bsd-license.php.