Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.21.8

Bug #6729 Veteran's Day wrong
Submitted: 2006-02-08 16:58 UTC
From: sprice Assigned: luckec
Status: Closed Package: Date_Holidays (version 0.15.1)
PHP Version: Irrelevant OS: Mac
Roadmaps: (Not assigned)    

 [2006-02-08 16:58 UTC] seth at pricepages dot org
Description: ------------ Veteran's day is marked incorrectly in the calendar. It looks like the code was copy-pasted, but someone forgot to change most of it. Here are the lines for Veteran's Day in Date/Holidays/ Driver/USA.php: $columbusDay = $this->_calcNthMondayInMonth(11,2); $this->_addHoliday('veteransDay',$columbusDay,'Veteran\'s Day'); (Which looks suspiciously like Columbus Day...) Veteran's Day should be the 11th day in November. While I'm here, I'll mention that the Christmas Day variable is $tday, which is a little odd... Maybe $cday would be more appropriate, but no harm done.


 [2006-02-11 22:42 UTC] luckec
Not enough information was provided for us to be able to handle this bug. Please re-read the instructions at If you can provide more information, feel free to add it to this bug and change the status back to "Open". Thank you for your interest in PEAR. Could you please provide more information on the date that the driver has calculated and the one you expected to be calculated? Thanks in advance!
 [2006-02-13 02:25 UTC] seth at pricepages dot org
Veteran's Day should be the 11th day in Nov, but you have it placed at the 2nd monday at Nov.
 [2006-04-01 17:20 UTC] schst (Stephan Schmidt)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on by the end of next Sunday (CET). If this was a problem with the website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.