Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.10.9

Bug #5385 small fix to PEAR/Command/Package.php and RunTest.php
Submitted: 2005-09-13 14:42 UTC
From: techtonik Assigned: cellog
Status: Closed Package: PEAR
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 42 - 40 = ?

 
 [2005-09-13 14:42 UTC] techtonik
Description: ------------ Patch one cosmetic Patch two functional Test script: --------------- --- Package_old.php Tue Sep 13 00:52:06 2005 +++ Package.php Tue Sep 13 15:54:46 2005 @@ -310,13 +310,11 @@ $pkginfofile = isset($params[0]) ? $params[0] : 'package.xml'; $pkg2 = isset($params[1]) ? $params[1] : null; if (!$pkg2 && !isset($params[0])) { - if (@file_exists('package2.xml')) { + if (file_exists('package2.xml')) { $pkg2 = 'package2.xml'; } } $packager = &$this->getPackager(); - $reg = &$this->config->getRegistry(); - $dir = dirname($pkginfofile); $compress = empty($options['nocompress']) ? true : false; $result = $packager->package($pkginfofile, $compress, $pkg2); if (PEAR::isError($result)) { Expected result: ---------------- --- RunTest_old.php Tue Sep 13 16:28:16 2005 +++ RunTest.php Tue Sep 13 16:34:14 2005 @@ -114,7 +114,7 @@ } fclose($fp); - $shortname = str_replace($cwd.'/', '', $file); + $shortname = str_replace($cwd.DIRECTORY_SEPARATOR , '', $file); if (!isset($this->_options['simple'])) { $tested = trim($section_text['TEST']) . "[$shortname]"; } else {

Comments

 [2005-09-13 15:20 UTC] cellog
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. please give descriptive names to bugs, no matter how funny you think the original one is.