Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.10.16

Bug #3801 [PATCH] analyzeSourceCode() reports PHP4 code as PHP5
Submitted: 2005-03-13 16:40 UTC
From: blindman Assigned: cellog
Status: Closed Package: PEAR
PHP Version: 4.3.10 OS: N/A
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 15 - 11 = ?

 
 [2005-03-13 16:40 UTC] blindman
Description: ------------ I am trying to package a PHP4 package. One of files contains HEREDOC strings with words "public" and "private", and this file is reported as being PHP5 code. This patch solves the problem: --- Common.php 2005-03-14 02:24:23.889665816 +1000 +++ Common_.php 2005-03-14 02:28:46.788699088 +1000 @@ -681,7 +681,7 @@ $data = ''; } if ($inquote) { - if ($token != '"') { + if ($token != '"' && $token != T_END_HEREDOC) { continue; } else { $inquote = false; @@ -697,6 +697,7 @@ } break; case '"': + case T_START_HEREDOC: $inquote = true; break; case T_CURLY_OPEN:

Comments

 [2005-03-16 23:26 UTC] cellog
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better.