Description: ------------ XML_RPC struct serialization fails to encode member name correctly when name contains XML entities. Test script: --------------- <?php require 'XML/RPC.php'; $param=new XML_RPC_Value(array('foo&bar'=>new XML_RPC_Value('foo & bar company','string')),'struct'); $msg=new XML_RPC_Message('none'); $msg->addParam($param); echo $msg->serialize(); ?> Expected result: ---------------- <?xml version="1.0" encoding="UTF-8"?> <methodCall> <methodName>none</methodName> <params> <param> <value><struct> <member><name>foo&bar</name> <value><string>foo & bar company</string></value> </member> </struct></value> </param> </params> </methodCall> Actual result: -------------- <?xml version="1.0" encoding="UTF-8"?> <methodCall> <methodName>none</methodName> <params> <param> <value><struct> <member><name>foo&bar</name> <value><string>foo & bar company</string></value> </member> </struct></value> </param> </params> </methodCall>

Added patch RPC-member-name-htmlentities.patch.

Expected result: ---------------- <?xml version="1.0" encoding="UTF-8"?> <methodCall> <methodName>none</methodName> <params> <param> <value><struct> <member><name>foo&bar</name> <value><string>foo & bar company</string></value> </member> </struct></value> </param> </params> </methodCall> Actual result: -------------- <?xml version="1.0" encoding="UTF-8"?> <methodCall> <methodName>none</methodName> <params> <param> <value><struct> <member><name>foo&bar</name> <value><string>foo & bar company</string></value> </member> </struct></value> </param> </params> </methodCall>

It seems that bug report form doesn't allow literal entities...so let's try for third time with extra spaces around entities: Expected result: ---------------- ... <member><name>foo& amp ;bar</name> <value><string>foo & amp ; bar company</string></value> ... Actual result: -------------- ... <member><name>foo&bar</name> <value><string>foo & amp ; bar company</string></value> ...

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Thanks for the patch, Kai! There's a few other places which look like this could occur; but I've left them alone - if you come across any more problems; let us know. Out of curiosity, XML_RPC2 is out - is there any reason you haven't migrated?

Thanks Daniel! We have few old in-house applications that are using old XML_RPC. Translated to English this means that I am just being lazy :)

Version 1.5.4 of this package has just been released and it includes this fix.