Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.4.0

Bug #13634 HTML_QuickForm2::__toString() must be compatible with that of HTML_Common2::__t
Submitted: 2008-04-09 14:26 UTC
From: saltybeagle Assigned: avb
Status: Closed Package: HTML_QuickForm2 (version CVS)
PHP Version: 5.2.4 OS:
Roadmaps: (Not assigned)    
Subscription  


 [2008-04-09 14:26 UTC] saltybeagle (Brett Bieber)
Description: ------------ Fatal error: Declaration of HTML_QuickForm2::__toString() must be compatible with that of HTML_Common2::__toString() in /Users/bbieber/Documents/workspace/pear/HTML_QuickForm2/QuickForm2.php on line 65 Two options I guess.... remove/change the abstract __toString for HTML_Common2 or change the __toString for QF2. related --- Bug #13024 abstract __toString() useless and inconsistent

Comments

 [2008-10-13 15:03 UTC] doconnor (Daniel O'Connor)
What Alexey has said on Bug #13024 what's in CVS are in conflict, and it feels like Bug #13024 should be the one to change.
 [2008-10-13 15:12 UTC] mansion (Bertrand Mansion)
I will change my use of __toString().
 [2008-10-13 15:16 UTC] avb (Alexey Borzov)
I think it would be sufficient to "implement" __toString() (see patch for bug #13024) in HTML_QuickForm2_Node until we decide on renderers implementation. I don't want to patch HTML_Common2, obviously.
 [2008-10-16 17:22 UTC] avb (Alexey Borzov)
After a bit of playing around I found that it was sufficient to change signature of HTML_QuickForm2::__toString() to public function __toString(HTML_QuickForm2_Renderer $renderer = null) Commited this to CVS.
 [2008-10-16 18:10 UTC] mansion (Bertrand Mansion)
That's nice, thank you :)