Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.2.9

Request #1160 Feature Addition: Simple Output on Benchmark_Iterate
Submitted: 2004-04-08 04:33 UTC
From: davey Assigned: toggg
Status: Closed Package: Benchmark
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 34 + 20 = ?

 
 [2004-04-08 04:33 UTC] davey
Description: ------------ I have made some minor improvements to Benchmark_Iterate, I changed the way it grabs the global variable when using objects - seems to be more stable using $GLOBALS array instead of "global". Additionally, I added an optional parameter to the Benchmark_Iterate::get() method to allow for minimal output. This change is completely backwards compatible - just a boolean field that defaults to the old behaviour. Patch is at http://pixelated-dreams.com/~davey/PEAR/patches/Benchmark_Iterate.txt - Davey

Comments

 [2004-04-08 06:14 UTC] sebastian at php dot net
The code of Benchmark_Iterate "smells" (in the Refactoring sense) and needs a rewrite badly. I lack the time to do this and don't have the motivation to find the time (I haven't used the class myself in years). If you would like to take over the maintainership of the class, fine ;-)
 [2005-06-11 12:24 UTC] toggg
Thank you for your bug report. This issue has been fixed in the latest released version of the package, which you can download at http://pear.php.net/get/Benchmark I could not take your modification striping the first char of object name as it is not conform to the documentation.