| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.16.14 |
| Bug #979 | Bug in processLogout() | ||
|---|---|---|---|
| Submitted: | 2004-03-09 12:43 UTC | ||
| From: | alain_d99 at freesurf dot ch | Assigned: | lsmith |
| Status: | Closed | Package: | LiveUser |
| PHP Version: | 4.2.1 | OS: | Windows |
| Roadmaps: | (Not assigned) | ||
[2004-03-09 12:43 UTC] alain_d99 at freesurf dot ch
Description:
------------
Hello,
LiveUser.php v1.80
The logout process doesn't work as expected.
The problem comes from the LiveUser::processLogout() that doesn't take the logout value from GET or POST method into account.
Line: ~1021
if (empty($handle)) {
$httpvar = (strtolower($this->_options['login']['method']) == 'post') ? $_POST : $_GET;
if (isset($httpvar[$this->_options['login']['username']]) &&
$httpvar[$this->_options['login']['username']] &&
isset($httpvar[$this->_options['login']['password']]) &&
$httpvar[$this->_options['login']['password']]
) {
$logout = true;
}
} else if($handle && $passwd) {
$logout = true;
}
would be:
if (empty($handle)) {
$httpvar = (strtolower($this->_options['login']['method']) == 'post') ? $_POST : $_GET;
if (isset($httpvar[$this->_options['login']['username']]) &&
$httpvar[$this->_options['login']['username']] &&
isset($httpvar[$this->_options['login']['password']]) &&
$httpvar[$this->_options['login']['password']]
) {
$logout = true;
} else if(isset($_GET[$this->_options['logout']['trigger']]) || // ADDED, NECESSARY
isset($_POST[$this->_options['logout']['trigger']])) { // ADDED
$logout = true;
}
} else if($handle && $passwd) {
$logout = true;
}
Now, LiveUser::processLogout() works perfectly well.
Thank for your work,
Alain
Expected result:
----------------
The logout process must work as expected.
Actual result:
--------------
The logout process doesn't work as expected: never log out.
Comments
[2004-03-09 12:56 UTC] lsmith
Ah, yes I wrote to the liveuser list about this a few hours ago. I wasnt sure where I lost this functionality, but I saw it was missing.
[2004-03-09 13:48 UTC] lsmith
hmm seems to me that we have to add a "method" and a "varname" option to the logout conf array.
[2004-03-09 14:23 UTC] lsmith
This bug has been fixed in CVS.
In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pear.php.net.
In case this was a pear.php.net website problem, the change will show
up on the website in short time.
Thank you for the report, and for helping us make PEAR better.