| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.5.6 |
| Request #2790 | [PATCH] getFormElements() | ||
|---|---|---|---|
| Submitted: | 2004-11-18 23:41 UTC | ||
| From: | ieure at php dot net | Assigned: | pmjones |
| Status: | Closed | Package: | DB_Table |
| PHP Version: | 4.3.9 | OS: | Linux |
| Roadmaps: | (Not assigned) | ||
[2004-11-18 23:41 UTC] ieure at php dot net
Description:
------------
This patch moves the logic to create form elements from
addElements() to getElements() (in DB_Table_QuickFormp),
and adds getFormElements() to DB_Table.
Patch (against CVS) is here:
http://atomized.org/PEAR/Patches/DB_Table-getElements.patch
Comments
[2004-12-20 18:31 UTC] pmjones
The patch generates two errors in DB/Table/Quickform.php:
Notice: Undefined variable: tmp in ... DB/Table/QuickForm.php on line 188
Notice: Undefined variable: tmp in ... DB/Table/QuickForm.php on line 190
Not sure what the $tmp variable is supposed to be doing in that logic, but it's not getting set.
I have made some changes to CVS today, be sure to update before you attempt to re-patch.
Thanks, Ian.
[2004-12-20 18:59 UTC] pmjones
This bug has been fixed in CVS.
In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pear.php.net.
In case this was a pear.php.net website problem, the change will show
up on the website in short time.
Thank you for the report, and for helping us make PEAR better.
Had to change "$this" to "DB_Table_QuickForm::" in Quickform.php line 184 (addElements has to be a static method). Otherwise appears to work just fine; thanks, Ian.