Bug #18188 :: Patch:many undefined indexes, like TEL in File_IMC_Build

Package home | Report new bug | New search | Development Roadmap

Status: Open | Feedback | All | Closed Since Version 0.5.0

Bug #18188	Patch:many undefined indexes, like TEL in File_IMC_Build_Vcard->addTelephone()
Submitted:	2011-01-13 04:07 UTC
From:	radoeka	Assigned:	till
Status:	Closed	Package:	File_IMC (version 0.4.1)
PHP Version:	5.3.1	OS:	linux
Roadmaps:	0.4.2
Subscription	Your email:

Comments Patches (1) Add Comment Add patch

Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !

Your email address: MUST BE VALID
Solve the problem : 4 + 39 = ?

[2011-01-13 04:07 UTC] radoeka (Richard Bos)

Description:
------------
Patch:many undefined indexes, like this:
TEL in File_IMC_Build_Vcard->addTelephone() (regel 1109 van
/usr/share/php5/PEAR/File/IMC/Build/Vcard.php)

For details see:
http://drupal.org/node/1021962

I've a patch attached.  Hopefully, you can commit it right away,
that would be nice.

Test script:
---------------
I use drupal, that creates a vcard for me.  The undefined notices are shown after the creation of the vcard on the webinterface.  It makes Drupal looking quite bad :(

Expected result:
----------------
No notices on the webinterface.

Actual result:
--------------
Many of those lines:
 * Notice: Undefined index: TEL in File_IMC_Build_Vcard-
/usr/share/php5/PEAR/File/IMC/Build/Vcard.php).
    * Notice: Undefined index: ADR in File_IMC_Build_Vcard-
/usr/share/php5/PEAR/File/IMC/Build/Vcard.php).
    * Notice: Undefined index: NAME in File_IMC_Build_Vcard-
/usr/share/php5/PEAR/File/IMC/Build/Vcard.php).
    * Notice: Undefined index: SOURCE in File_IMC_Build_Vcard-
/usr/share/php5/PEAR/File/IMC/Build/Vcard.php).
    * Notice: Undefined index: PHOTO in File_IMC_Build_Vcard-
/usr/share/php5/PEAR/File/IMC/Build/Vcard.php).

Comments

[2011-01-14 21:11 UTC] till (Till Klampaeckel)

-Status:      Open
+Status:      Feedback
-Assigned To:
+Assigned To: till
Not enough information was provided for us to be able
to handle this bug. Please re-read the instructions at
http://bugs.php.net/how-to-report.php

If you can provide more information, feel free to add it
to this bug and change the status back to "Open".

Thank you for your interest in PEAR.


Hey,

thanks for the bug report -- can you re-attach the patch?

Till

[2011-01-14 21:16 UTC] till (Till Klampaeckel)

-Status: Feedback
+Status: Analyzed
Ok, patch is on Bug #18189 ! :-)

[2011-01-15 00:42 UTC] radoeka (Richard Bos)

Added patch Vcard_prevent_undefines.

[2011-01-15 00:42 UTC] radoeka (Richard Bos)

Patch applied

[2011-01-15 22:52 UTC] radoeka (Richard Bos)

Sorry the previous update "Patch applied" should be Patch attached.

[2011-03-11 22:15 UTC] till (Till Klampaeckel)

-Status:           Analyzed
+Status:           Closed
-Roadmap Versions:
+Roadmap Versions: 0.4.2
This bug has been fixed in SVN.

If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

Thanks again for the patch. Will release shortly!