| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.10.15 |
| Bug #15747 | REST for PEAR_Command_Install tests | ||
|---|---|---|---|
| Submitted: | 2009-01-24 03:48 UTC | ||
| From: | doconnor | Assigned: | dufuz |
| Status: | Closed | Package: | PEAR (version CVS) |
| PHP Version: | 5.2.6 | OS: | |
| Roadmaps: | 1.8.0alpha1 | ||
[2009-01-24 03:48 UTC] doconnor
(Daniel O'Connor)
Description:
------------
A quick patch.
There are some failures that scare me (undefined variables, for instance)
Comments
[2009-01-24 03:50 UTC] doconnor
(Daniel O'Connor)
tests/PEAR_Command_Install/upgrade-all/test.phpt
produces:
Notice: Undefined variable: dorest in /usr/share/php/PEAR/Command/Install.php on line 1222
Notice: Undefined variable: latest in /usr/share/php/PEAR/Command/Install.php on line 1230
Notice: Undefined variable: latest in /usr/share/php/PEAR/Command/Install.php on line 1236
Warning: array_change_key_case(): The argument should be an array in /usr/share/php/PEAR/Command/Install.php on line 1236
[2009-01-24 04:01 UTC] doconnor
(Daniel O'Connor)
test_dependsonpecl.phpt produces:
Notice: Undefined property: PEAR_test_mock_pearweb::$_restCalls in /home/clockwerx/pear-cvs/pear-core/tests/PEAR_test_mock_pearweb.php.inc on line 75
[2009-01-24 04:04 UTC] doconnor
(Daniel O'Connor)
test_extinstall.phpt produces:
Warning: rmdir(/home/clockwerx/pear-cvs/pear-core/tests/PEAR_Command_Install/testinstallertemp): Directory not empty in /home/clockwerx/pear-cvs/pear-core/tests/download_test_classes.php.inc on line 826
... which shouldn't be tricky to fix
[2009-01-24 04:23 UTC] doconnor
(Daniel O'Connor)
The Install.php patch might not be entirely correct; but I think I've got it.
It:
1. Doesn't worry about $dorest, it just always looks for REST from the channel server
2. If the channel server doesn't support rest, raises an error
The tests still fail because the test setup isn't right.
[2009-03-08 08:04 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: dufuz
-Roadmap Versions:
+Roadmap Versions: 1.8.0alpha1
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.