Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.1.2

Request #14162 want to use other licenses
Submitted: 2008-06-17 09:26 UTC
From: hshimooka Assigned: hm2k
Status: Closed Package: PHP_DocBlockGenerator (version 1.1.1)
PHP Version: 5.2.6 OS:
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 28 - 14 = ?

 
 [2008-06-17 09:26 UTC] hshimooka (Hideyuki Shimooka)
Description: ------------ If I want to use 'MY' license, perhaps I must not use '--license' option and write that licese per script file. So I made a patch against License.php: http://coderepos.org/share/browser/lang/php/PHP_DocBlockGenerator/PHP/DocBlockGenerator/License.php.patch?rev=14166&format=raw and modified License.php is: http://coderepos.org/share/browser/lang/php/PHP_DocBlockGenerator/PHP/DocBlockGenerator/License.php?rev=14166 The license files will be located in PEAR_INSTALL_DIR/data/PHP_DocBlockGenerator/: http://coderepos.org/share/browser/lang/php/PHP_DocBlockGenerator/data/PHP_DocBlockGenerator?rev=14166 In a license file, the 1st line is 'full_name', the 2nd is 'url' and 'text' is follwing.

Comments

 [2010-08-10 00:18 UTC] hm2k (James Wade)
-Status: Open +Status: Analyzed
I understand why you have done this as it does not really make sense to have such information hard coded, but at present I'm not convinced it's exactly the best way of doing this. Thanks for your input, I will have a think.
 [2010-08-10 00:19 UTC] hm2k (James Wade)
-Assigned To: +Assigned To: hm2k
 [2011-09-06 18:35 UTC] hm2k (James Wade)
Since "XML" is a recognised standard with pear (ie: package2.xml), it may be better to use XML files instead of text files. The benefit of XML over text is that it's a recognised standard, rather than adhoc. I'm now considering how they should be formatted and whether they should be all in one file or separate files...
 [2011-09-06 19:57 UTC] hm2k (James Wade)
The issue at the moment is discovering a suitable XML format. I've been doing some searching to see if I can find any examples of existing formats, eg: "Licensed under the Apache License, Version 2.0" filetype:xml inurl:apache or "Redistributions in binary form must reproduce the above copyright notice" filetype:xml inurl:bsd But nothing conclusive showed up there. I went on to search for: inurl:license filetype:xml This was a bit more interesting... http://repository.jboss.org/licenses/license-info.xml http://repository.jboss.org/licenses/ I concluded that the best solution appears to be a combination of plain text files for the actual licenses, then an xml file to index them. I also came across this: http://licenses.opendefinition.org/ Which could provide the url and title details, meaning there is no need for an XML index file.
 [2011-09-06 20:28 UTC] hm2k (James Wade)
Interestingly PHP_Beautifier has a licenses directory: https://github.com/clbustos/PHP_Beautifier/tree/master/licenses They are included in the packages2.xml: https://github.com/clbustos/PHP_Beautifier/blob/master/package2.xml And appears to be used as follows: Beautifier\Filter\Pear.filter.php: $sDataPath = PHP_Beautifier_Common::normalizeDir($oConfig->get('data_dir')) . 'PHP_Beautifier/licenses/' . $sLicense . '.txt'; However, PHP_Beautifier does not include a URL or full name, so that will still need to be handled in some kind of simple index file (xml, json, txt or ini). For now, I may keep the index php based and get the license files right first.
 [2011-09-06 22:05 UTC] hm2k (James Wade)
-Status: Analyzed +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.