Description: ------------ According to package documentation the Translation2_Admin::updateLang() supposed to return true on success or PEAR_Error on failure. This is not the case with mdb2 driver because 'query' method in mdb2 does not return true on success, but instead returns an MDB2_Result handle The fix: in Admin/Container/mdb2.php find lines: $success = $this->db->query($query); $this->fetchLangs(); //update memory cache return $success; and replace with $success = $this->db->query($query); if (true != PEAR::isError($success)) { $success = true; } $this->fetchLangs(); //update memory cache return $success;

> This is not the case with mdb2 driver because 'query' > method in mdb2 I think, the real "bug" is: Why is $this->db->query() used (not only in this method)? UPDATE or INSERT are manipulation statements, thus $this->db->exec() should be used. > $success = $this->db->query($query); > $this->fetchLangs(); //update memory cache > return $success; Should be: | if (PEAR::isError($success = $this->db->exec($query))) { | return $success; | } | $this->fetchLangs(); //update memory cache | return (bool) $success; Regards, Carsten

Yep, there's a mismatch between the docs and the actual behaviour, I'll fix it soon. Regarding the use of "query()" instead of "exec()", it's because "exec()" didn't exist at the time that Translation2 was written. I'll fix that too.

This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.