Description: ------------ I'll describe with an example: SELECT *, a FROM Foo will cause the parser to fail. Test script: --------------- require_once 'SQL/Parser.php'; require_once 'SQL/Compiler.php; $parser = new SQL_Parser(null, 'MySQL'); $compiler = new SQL_Compiler(); $res = $parser->parse("SELECT *,a from Foo"); if ( PEAR::isError($res) ) echo "Failed"; else echo $compiler->compile($res); // should print "select *, a from Foo" I have corrected this problem in my local version. This is the diff file: 75c75 < $this->types, --- > $this->types, 833,836c833,834 < if ($this->token == '*') { < $tree['column_names'][] = '*'; < $this->getTok(); < } elseif ($this->token == 'ident' || $this->isFunc()) { --- > > if ($this->token == 'ident' || $this->isFunc() || $this->token == '*') { 838c836 < if ($this->token == 'ident') { --- > if ($this->token == 'ident' || $this->token == '*') { 852a851,852 > } else if ($prevTok == '*' ){ > $columnName = $prevTok; 857c857 < if ($this->token == 'as') { --- > if ($this->token == 'as') { Expected result: ---------------- select *, a from Foo Actual result: -------------- Failed

Yes, now that I think about it, the check for '*' does break from a loop (prematurely). Thank you. I'll take a look at this in the next couple days. Erich

Thank you for the patch. Unfortunately, the patch breaks other things, apparent from running the unit tests. I will continue to track this down. I have added this test to our testing suite. :) Erich

This is fixed now.