Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.10.15

Request #2848 PEAR_ErrorStack logger extends
Submitted: 2004-11-28 22:07 UTC
From: farell Assigned: cellog
Status: Closed Package: PEAR
PHP Version: 4.3.9 OS: Windows XP
Roadmaps: (Not assigned)    
Subscription  


 [2004-11-28 22:07 UTC] farell
Description: ------------ As requested by Greg, in reply to my post on pear-dev mailing list: http://news.php.net/php.pear.dev/34621 All details of my proposal are behind this link: http://pear.laurent-laville.org/PEAR_ErrorLayer/errorstack_140dev1.html

Comments

 [2004-12-22 07:19 UTC] farell
I've changed the URL of my initial proposal, including also the new feature to halt a script after send it to any logger. See now http://pear.laurent-laville.org/proposals/errorstack_140dev.html
 [2005-01-01 21:26 UTC] cellog
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better. the only thing that is blatantly wrong is the removal of the return in setContextCallback(). If the user wishes to turn off a context callback, they pass in null. Without the return, it is turned on again if ($contextCallback === null) { $this->_contextCallback = false; } if (!$contextCallback) { $this->_contextCallback = array(&$this, 'getFileLine'); see? As for the rest of the patch, I implemented the logging more simply if $logger is a 'Log', it assumes it is a PEAR::Log object, otherwise, just pass in array(&$log, 'log') for non-PEARLog objects, and call_user_func($logger, $err) is used.