Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.0.2
Bug #19852 usage of die()
Submitted: 2013-03-12 00:08 UTC
From: cweiske Assigned: wenz
Status: Closed Package: Text_CAPTCHA
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    
Subscription  


 [2013-03-12 00:08 UTC] cweiske (Christian Weiske)
Description: ------------ Text_Figlet uses die() without any notice when it does not get options passed, which is very bad for error handling. Please remove the die() call and rather return a PEAR_Error object when some configuration option is missing.

Comments

 [2013-03-12 00:51 UTC] cweiske (Christian Weiske)
-Package: Text_Figlet +Package: Text_CAPTCHA
 [2013-03-12 00:51 UTC] cweiske (Christian Weiske)
Replace Text_Figlet with Text_CAPTCHA_Driver_Figlet.
 [2013-03-12 01:00 UTC] cweiske (Christian Weiske)
Added patch figlet-fonterror.diff.
 [2013-03-15 13:31 UTC] cweiske (Christian Weiske)
Unit test: https://github.com/cweiske/Text_CAPTCHA/commit/9f401904b94584bfa7d16552c089463e511236f9
 [2013-03-16 18:58 UTC] wenz (Christian Wenz)
-Status: Open +Status: Closed -Assigned To: +Assigned To: wenz
Thank you for your bug report. This issue has been fixed in the latest released version of the package, which you can download at http://pear.php.net/get/ thanks! Removed the die() call, and also took care of the case if no options are provided at all.