Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.1.14
Bug #17729 patch: Removed define_syslog_variables and avoided warning for socket blocking
Submitted: 2010-08-18 02:23 UTC
From: olleolleolle Assigned: garrettw
Status: Closed Package: Net_SmartIRC (version SVN)
PHP Version: 5.3.1 OS:
Roadmaps: 1.1.0    
Subscription  


 [2010-08-18 02:23 UTC] olleolleolle (Olle Jonsson)
Description: ------------ Removed the define_syslog_variables() call, which is not needed to use the syslog constants. This avoids a deprecation warning. A new syntax has been invented for socket_set_blocking(), too. The attached patch takes care of these two warnings.

Comments

 [2010-08-18 02:23 UTC] olleolleolle (Olle Jonsson)
Added patch avoid_deprecated.patch.
 [2010-08-24 05:19 UTC] doconnor (Daniel O'Connor)
r302734 applies the stream_set_blocking bit. If memory serves, removing define_syslog_variables() will... well, leave the syslog variables undefined in old php versions. I don't suppose you can do some kind of ... if (!defined()) { // raise an error, pester user to ini_set define_syslog_variables ? }
 [2010-08-24 06:48 UTC] doconnor (Daniel O'Connor)
-Assigned To: +Assigned To: olleolleolle
 [2011-04-25 12:52 UTC] doconnor (Daniel O'Connor)
The alternative simply being to support only 5.3+ in the next major release
 [2011-04-26 13:52 UTC] olleolleolle (Olle Jonsson)
In that case, I vote for the alternative of only supporting 5.3. Now it seems like a much more viable way forward.
 [2011-05-10 10:30 UTC] garrettw (Garrett Whitehorn)
I'm working on a patch that sniffs PHP's version to determine whether to call this function or not.
 [2014-02-05 08:24 UTC] doconnor (Daniel O'Connor)
-Status: Assigned +Status: Closed -Assigned To: olleolleolle +Assigned To: garrettw
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.