Description: ------------ Net_IDNA causes an E_NOTICE because of the way it returns a reference to the class instance. The attached patch (against 0.7.1, since the CVS is non-responsive) fixes this. Test script: --------------- <?php include 'Net/IDNA.php'; $idna = &Net_IDNA::getInstance(); ?> Expected result: ---------------- No output. Actual result: -------------- Notice: Only variable references should be returned by reference in /usr/share/pear/Net/IDNA.php on line 65 Call Stack: 0.0003 1. {main}() /tmp/test.php:0 0.0010 2. Net_IDNA::getInstance() /tmp/test.php:3

This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.

The attached patch will still cause a notice in the case that false is returned and is less efficient for PHP4 (I presume that's the entire reason a reference is returned). I have a revised patch that addresses these two problems. This maintains PHP4 compatibility and efficiency while preventing notices in PHP5.