Vote Details for "Figlet" by danielc

» Details
  • Voter: Daniel Convissor 
  • Vote: +1 (conditional)
  • Reviews: Cursory source review
» Comment
Cute tool.

Here are some additional minor coding standards fixes, please:

1) Put the ":" in the $Id:$ tag.

2) Private property names (meaning the var's) need to be preceeded with an underscore (example: "var $_foo;")

3) echoLine() is a better OO name than lineEcho(). Action first, subject second.

4) Re the docblocks: the indenting on the ones above the vars is good. The ones above the methods need to have the additional rows nudged in one space so the subsequent asterisks line up with the first asterisk. Also, it'd be nice to remove the space between the comments and the items they are commenting on. All this is as per JavaDoc standards and now coverd in the coding standards sample file: