Vote Details for "Services_Memotoo" by jausions

» Details
Voter: Philippe Jausions [Wishlist] Vote: +1 (not conditional) Reviews: Cursory source review
» Comment
In package.xml you marked all the examples as type="test", I guess it works, still a bit weird though. Make sure to run PHP_CodeSniffer on your code, I'm pretty sure it'll at least complain about the missing "PHP version 5" in the file's docBlock. You don't really need to have @access docTag once you declare the methods with their scope. I'd like to see a bit of "breathing" spaces in the for() lines, i.e. put spaces after ; and around "<", and so on... When everything is jammed together it makes it a little bit harder to read.