Vote Details for "File_MARC" by aharvey

» Details
  • Voter: Adam Harvey 
  • Vote: +1 (not conditional)
  • Reviews: Cursory source review, Run examples
» Comment
There were a couple of minor issues with the examples that I noticed. marc_yaz.php tries to call File_MARC::numRecords(), which doesn't seem to exist. Also, read.php prints the message "Surname: Error -- $a subfield appears more than once in this field!" -- is this expected?

Apart from that, the source itself looks good, bar the minor issues the other voters have mentioned. Throwing a random MARC file at it and hacking a script up to pull information out worked, and that's the main thing.