Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.5.0b5

Bug #9024 Various uninitialized variables
Submitted: 2006-10-14 10:00 UTC
From: jo at durchholz dot org Assigned: quipo
Status: Closed Package: MDB2 (version 2.2.2)
PHP Version: Irrelevant OS: Any
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 22 - 7 = ?

 
 [2006-10-14 10:00 UTC] jo at durchholz dot org (Joachim Durchholz)
Description: ------------ Here's a list of uninitialized variables in MDB2 and used MDB2 drivers (ibase, mssql, mysql, and pgsql) that running an MDB2-based project through Eclipse uncovered: Variable Path File Line -------------------------------------------------------- $created_objects MDB2 Schema.php 450 $result MDB2/Driver ibase.php 325 $results MDB2/Driver/Manager mssql.php 217 $results MDB2/Driver/Manager mssql.php 231 $default_table_type MDB2/Driver mysql.php 159 $match MDB2/Driver pgsql.php 244 These look like real bugs to me, i.e. code that wasn't updated after changes elsewhere ($created_objects, $result), variable name typos ($results), trying to access the wrong variable ($default_table_type), or overlooked variable initialization ($match). (Splitting this up into a separate bug report per package would do these bugs far too much honor.)

Comments

 [2006-10-14 16:20 UTC] lsmith (Lukas Smith)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Lorenzo fixed most of these. I disabled the code in the pgsql driver for now and fixed the issue in the Schema file.
 [2006-10-14 20:07 UTC] quipo (Lorenzo Alberton)
I also fixed the code in the pgsql driver. Can you grab the CVS version of the package and tell us if all the "uninitialized variable" errors have been fixed? I didn't find them on the line numbers you reported, maybe you had an old version? Thanks for your help!
 [2006-10-15 07:03 UTC] jo at durchholz dot org
Sorry, I forgot the package versions, here they are: ibase: 1.2.1 (current) mssql: 1.1.0 (current) mysql: 1.2.2 (current) pgsql: 1.2.2 (current) For Lorenzo: I'm not sure what exactly went wrong, maybe there was a copy&paste error involved. The real uninitialized $match is at line 680. I'm unable to check back via CVS right now. I'd have to configure it to use CVS in one part of the project, where everything else uses SVN, and I'm not sure how to do that without damaging the existing project (yesterday was my first day with Eclipse...). I'll start doing CVS checkouts once I'm more familiar with Eclipse :-)