| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.6.2 |
| Request #8569 | Make "requiredNote" more dom-friendly | ||
|---|---|---|---|
| Submitted: | 2006-08-27 22:05 UTC | ||
| From: | eduardo593734256 at gmail dot com | Assigned: | wiesemann |
| Status: | Closed | Package: | HTML_QuickForm_Renderer_Tableless (version 0.3.3) |
| PHP Version: | Irrelevant | OS: | Gnu/Linux |
| Roadmaps: | (Not assigned) | ||
[2006-08-27 22:05 UTC] eduardo593734256 at gmail dot com
(Eduardo Marinho)
Description:
------------
This element needs a DOM node so it can be styled.
Test script:
---------------
Line 99, Tableless.php:
From:
"\n\t\t{requiredNote}";
To:
"\n\t\t
{requiredNote}
";Comments
[2006-09-12 10:53 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!
[2006-09-12 17:26 UTC] eduardo593734256 at gmail dot com
Hi, Mark!
In the original renderer, the method is useful because the template is hard coded with "align" and else, so it's the way to quickly change it.
In your renderer, not putting the notes in a DOM acessible place by default looks equivalent to hard coding the fixed style in the renderer, since you need to change the code, not the CSS, to do something related to the layout, which goes against the renderer's purpose. (at least in our case)
Plus, this change would add many more use cases to the default behavior and reduce 1 duplicated line per form in most use cases.
[2006-09-14 09:53 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!
[2006-09-14 19:47 UTC] eduardo593734256 at gmail dot com
This looks like a problem in QF itself, since it's setting in RequiredNote data that should be in RequiredNoteTemplate exclusively.
I didn't knew about this problem because I always have to translate the message in my forms, so this default formatting was always overwritten with a clean message. What to do? Should I report it to QF?
[2006-09-14 20:05 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!
[2006-09-15 03:34 UTC] eduardo593734256 at gmail dot com
I got your points, I think it is the best solution.
My suggestion for the class name: "star" or "indicator"
.qf_req_note .star {/* stuff */}
* denotes required field
[2006-09-15 07:52 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!
[2006-09-17 10:57 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!
[2006-09-18 05:32 UTC] eduardo593734256 at gmail dot com
Ah! Sorry, I forgot about it, been too long seeing only
client validation.
It's really much better and consistent.
Thank you for the help and attention, I checked the new
source, will update my style sheet here and wait for the
release. :-)
[2006-09-18 19:32 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!