Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.6.4

Bug #855 [PATCH] Auth::changePassword implementation
Submitted: 2004-02-25 22:55 UTC
From: cipri Assigned: yavo
Status: Closed Package: Auth
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: (Not assigned)    
Subscription  


 [2004-02-25 22:55 UTC] cipri
Description: ------------ I created a patch[1] for Auth that implements a changePassword function. It accepts two simple arguments(username, new password) and returns true, false, or AUTH_METHOD_NOT_SUPPORTED. It's documented, commented, and tested. I also provided implementations for this method in all 4 containers that currently support Adding/removing users. DB, File, MDB, and SMBPasswd. All worked fine in my test environment. The generic Container also implements an empty function that merely returns AUTH_METHOD_NOT_SUPPORTED, and Auth itself implements a function that calls the Container's function. Each function was added using the same CS and style as the other functions around it so they'll be easy to maintain by the curreny maintainers. I also fixed some typo's in the inline-documentation, updated some minor strings/docs/comments to make them easier to understand, and fixed some CS violations ( if(..){, else on seperate lines, whitespace). I also added this function to the package.xml'sc Changelog. Sorry if this is bad practice :) This patch includes the patch provided by "m at tacker dot org " in Bug #798 [2] for DB.php. Also, I noticed the docs for Auth[3] are somewhat outdated. THey don't mention the new add/remove user functions, nor some of the other new functions of the program. Could someone advise how I'd best proceed to get these added to the manual? :) Could someone please import this patch into CVS? Thanks in advance :) [1] http://www.cipri.com/pear/Auth.diff.txt [2] http://pear.php.net/bugs/bug.php?id=798 [3] http://pear.php.net/manual/en/package.authentication.php

Comments

 [2004-03-28 23:17 UTC] yavo at php dot net
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better.