Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 3.4.2

Bug #20240 Squiz block comment sniff fails when newline present
Submitted: 2014-04-10 22:12 UTC
From: brodkin Assigned: squiz
Status: Closed Package: PHP_CodeSniffer (version 1.5.2)
PHP Version: 5.5.10 OS: Mac OS 10.9.2
Roadmaps: (Not assigned)    
Subscription  


 [2014-04-10 22:12 UTC] brodkin (Ryan Brodkin)
Description: ------------ While this may be a rare use case, Squiz.Commenting.BlockComment.NoEmptyLineAfter triggers when there is a new line following the comment block but that newline is also the end of the file. Test script: --------------- /* BLOCK COMMENT */ EOF Expected result: ---------------- New line following block comment should pass. Actual result: -------------- PHPCS reports error "Empty line required after block comment"

Comments

 [2014-04-30 06:43 UTC] squiz (Greg Sherwood)
-Status: Open +Status: Closed -Assigned To: +Assigned To: squiz
Fix committed to github repo: https://github.com/squizlabs/PHP_CodeSniffer/commit/34903295738c66ad8ea87c04a d6eaa1477700868 Only occurred when there was no code (only whitespace) after the block comment.