Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.1.14

Request #18403 Bug fixes, code formatting, added features
Submitted: 2011-03-28 15:55 UTC
From: garrettw Assigned: garrettw
Status: Closed Package: Net_SmartIRC (version 1.0.2)
PHP Version: Irrelevant OS:
Roadmaps: 1.1.0    

 [2011-03-28 15:55 UTC] garrettw (Garrett Whitehorn)
Description: ------------ The attached patch files fix bugs 13079, 16531, 16755, 17729, and 17769. I also took the liberty of reformatting some of the code and comments to comply with PEAR Coding Standards. It will still need more work though, as this is only a partial fix. Also, all patches must be applied at the same time due to some changes in the class names. Lastly, I've added support for PHP's newer __construct()/__destruct() methods which can now be used in place of module_init()/module_exit(). The latter methods are still supported for backward-compatibility. I *think* that's everything, and I hope this patch works! :)


 [2011-03-30 04:15 UTC] till (Till Klampaeckel)
Hey Garrett, do you mind creating a unified diffs? They are more readable and easier for me to apply. Otherwise, patches look fine to me. Great job! Would you be interested in helping out on this package? Till
 [2011-03-30 15:12 UTC] till (Till Klampaeckel)
-Assigned To: +Assigned To: till
 [2011-03-30 18:40 UTC] garrettw (Garrett Whitehorn)
Sorry -- I used WinMerge to create those. I'll have to look into using diff on Windows or something. And yes, I'd love to help out -- that's actually why I did this. meebey told me to submit a patch as a coding sample for his evaluation before he'd add me to it.
 [2011-05-05 10:35 UTC] garrettw (Garrett Whitehorn)
Original patch links have been updated with new unified diffs.
 [2014-02-05 11:38 UTC] garrettw (Garrett Whitehorn)
-Status: Assigned +Status: Closed -Assigned To: till +Assigned To: garrettw
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on by the end of next Sunday (CET). If this was a problem with the website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. The bugs mentioned have been fixed on github. I'll add the other stuff when I get to it now that I'm a maintainer :)