Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 3.4.2

Request #18282 Squiz doesn't handle 'final' keyword before function comments
Submitted: 2011-02-17 19:22 UTC
From: recurser Assigned: squiz
Status: Closed Package: PHP_CodeSniffer (version 1.3.0RC2)
PHP Version: 5.3.1 OS: ubuntu
Roadmaps: (Not assigned)    
Subscription  


 [2011-02-17 19:22 UTC] recurser (Dave Perrett)
Description: ------------ Squiz spits out a bunch of complaints if functions are defined using the 'final' keyword. Need to add _T_FINAL_ to the _$ignore_ list in the _process()_ functions : Standards/Squiz/Sniffs/Commenting/BlockCommentSniff.php 74d73 < T_FINAL, Standards/Squiz/Sniffs/Commenting/InlineCommentSniff.php 85d84 < T_FINAL, Expected result: ---------------- No errors. Actual result: -------------- 43:5 Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead Squiz.Commenting.InlineComment.DocBlock 44:1 First line of comment not aligned correctly; expected 8 spaces but found 5 Squiz.Commenting.BlockComment.FirstLineIndent 44:1 Block comments must start with a capital letter Squiz.Commenting.BlockComment.NoCaptial 45:1 Comment line indented incorrectly; expected at least 8 spaces but found 5 Squiz.Commenting.BlockComment.LineIndent 46:1 Comment line indented incorrectly; expected at least 8 spaces but found 5 Squiz.Commenting.BlockComment.LineIndent 47:1 Last line of comment aligned incorrectly; expected 4 spaces but found 5 Squiz.Commenting.BlockComment.LastLineIndent 47:1 Empty line required after block comment Squiz.Commenting.BlockComment.NoEmptyLineAf

Comments

 [2011-02-18 11:26 UTC] squiz (Greg Sherwood)
-Status: Open +Status: Closed -Assigned To: +Assigned To: squiz
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.