Description: ------------ The __destruct() of the generated parser can go into an infinite loop. Test script: --------------- # cat test.php %name TEST_ %token_prefix TEST_ %declare_class {class test} %include { $a = new test(); $a->lala(); } %include_class { public function lala() { exit(1); } } start ::= . # cat create_parser.php require_once(dirname(__FILE__)."/../../../../lib/parser_generator/ParserGenerator.php"); $parser = new PHP_ParserGenerator(); $parser->main(); # php create_parser.php test.y Expected result: ---------------- Program terminates... Actual result: -------------- Infinite loop in the __destruct code while ($this->yyidx >= 0) { $this->yy_pop_parser_stack(); } since $this->yyidx===0 and $this->yystack===Array(), and $this->yy_pop_parser_stack(); does if (!count($this->yystack)) { return; }

I think this is a duplication of bug #12730.

Agreed. But mine has a test case :). In any case, it is trivial to fix. #12730 has a fix, and I have a (slightly better, perhaps) fix in my private tree.

Please, add the patch here to apply it to the package.

My fix was simply to use $this->yystack !== Array() for checking whether the stack was empty, instead $yyidx . This way, it will not go into an infinite loop even if $yyidx gets out of sync. Something like while ($this->yystack !== Array()) { $this->yy_pop_parser_stack(); }

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Applied the patch of Thue Kristensen