Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.3.7

Request #16659 Net_CheckIP > Net_CheckIP2
Submitted: 2009-09-30 01:51 UTC
From: till Assigned: nohn
Status: Closed Package: Net_DNSBL (version 1.3.3)
PHP Version: Irrelevant OS:
Roadmaps: 1.3.5    

 [2009-09-30 01:51 UTC] till (Till Klampaeckel)
Description: ------------ Hi, was wondering if you considered updating to Net_CheckIP2. I'm close to a stable release, this is RC3: To switch, just replace the following calls: Net_CheckIP::check_ip($foo); with: Net_CheckIP2::isValid($foo); I also added a bunch of other methods to the package, let me know if you have some time to check it out, I'd appreciate the feedback. Till


 [2009-09-30 01:51 UTC] till (Till Klampaeckel)
 [2009-09-30 17:43 UTC] nohn (Sebastian Nohn)
-Assigned To: +Assigned To: nohn
 [2009-09-30 17:43 UTC] nohn (Sebastian Nohn)
I'll check that as soon as it is stable.
 [2009-09-30 19:54 UTC] till (Till Klampaeckel)
Sounds good, also, if you have feedback -- I'm trying to finalize this package and once it's stable, the API will be as-is. So if you have additions beforehand, please let me know.
 [2010-07-21 13:15 UTC] hm2k (James Wade)
Why not change dependencies from Net_CheckIP to filter_var with FILTER_VALIDATE_IP?
 [2010-07-21 19:31 UTC] till (Till Klampaeckel)
I just looked at this again since I'm still subscribed. It's probably hard to do either - Net_CheckIP2 or filter_var(). Why? Because Net_DNSBL is a PHP4 package and switching to either solution is a BC break. Net_DNSBL2 is probably due.
 [2011-02-10 18:42 UTC] hm2k (James Wade)
If you truly believe that, why not close this as "Wont Fix"?
 [2011-02-10 18:45 UTC] hm2k (James Wade)
This change seems to suggest otherwise: r1=304645&r2=304646 Applying the patch in bug #17617 will also fix this.
 [2011-02-10 19:08 UTC] hm2k (James Wade)
In those changes you made there, you removed the following: require_once 'Net/CheckIP.php'; This results in the following error: PHP Fatal error: Class 'Net_CheckIP' not found in Net/DNSBL.php on line 287 This needs to be fixed asap!
 [2011-02-10 21:19 UTC] hm2k (James Wade)
-Status: Assigned +Status: Closed -Roadmap Versions: +Roadmap Versions: 1.3.5
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on by the end of next Sunday (CET). If this was a problem with the website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. CheckIP is no longer needed.