Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.14.4

Request #12839 Let the 'mail' handler use the Mail package
Submitted: 2008-01-06 15:51 UTC
From: wiesemann Assigned: jon
Status: Closed Package: Log (version 1.9.14)
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: 1.10.0    
Subscription  


 [2008-01-06 15:51 UTC] wiesemann (Mark Wiesemann)
Description: ------------ If the 'mail' handler would use the PEAR::Mail package, it would be a lot easier to use this handler on Windows. I can take care of either modifying the existing handler or of adding a new handler that uses the Mail package, if this request is reasonable.

Comments

 [2008-01-16 16:51 UTC] wiesemann (Mark Wiesemann)
Jon, I saw that you had this request on the roadmap for the last release. Can you please give me a short feedback? Do you want to fulfill this request? If yes, do you want to modify the existing mail driver or do you want to make a new driver? Do you want to work on this yourself or should a provide a patch?
 [2008-01-18 02:39 UTC] jon (Jon Parise)
I don't think I assigned this request to a previous roadmap, but, if I did, I must have done so by mistake. I've just created a roadmap for the next feature release (1.10.0) and assign this issue there. I think the best approach is to update the existing mail handler to optionally use the Mail package. If you can provide a patch to do so, it would be a big help.
 [2008-01-24 18:19 UTC] wiesemann (Mark Wiesemann)
> I don't think I assigned this request to a previous > roadmap, but, if I did, I must have done so by mistake. Yes, very likely. The email with the unassignment came only a few seconds later. ;-) A first patch is ready. If you have comments, I can do the needed changes.
 [2008-01-24 18:21 UTC] wiesemann (Mark Wiesemann)
I forgot to mention that you might don't like the usage of require_once (maybe include_once is better here?) and the initialization of the Mail class in close() instead of in the constructor. It's your choice, you know the design of the Log package better than me.
 [2008-02-04 06:27 UTC] jon (Jon Parise)
This looks pretty good. I'm going to try to give it a detailed look later this week.
 [2008-02-10 00:19 UTC] jon (Jon Parise)
I've committed your patch to CVS with two small changes: - I changed the require_once() call to include_once(). - I removed the internal error logging to avoid any problems with logging loops that might occur when the package is being used to handle native PHP errors. I also updated the users guide to reflect the new feature. Please take a look at the code in CVS and let me know how it looks. Thanks again for your contribution!
 [2008-02-10 11:30 UTC] wiesemann (Mark Wiesemann)
> Please take a look at the code in CVS and let me know how > it looks. You haven't changed much of my patch, and those parts that you have changed make sense. Thanks for integrating my request.