Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.32.0

Request #10575 link to page in pearweb/notes
Submitted: 2007-03-31 18:25 UTC
From: moosh Assigned: davidc
Status: Closed Package: pearweb
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    

 [2007-03-31 18:25 UTC] moosh (Christophe Gesché)
Description: ------------ pending notes are shown on all pages, this patch add a link to the page from where was posted the note. Test script: --------------- Index: templates/notes/note.tpl.php =================================================================== RCS file: /repository/pearweb/templates/notes/note.tpl.php,v retrieving revision 1.1 diff -U 3 -r1.1 note.tpl.php --- templates/notes/note.tpl.php 22 Mar 2007 23:40:01 -0000 1.1 +++ templates/notes/note.tpl.php 31 Mar 2007 17:28:12 -0000 @@ -1,5 +1,7 @@ <?php if ($pending) { ?> -<div class="pending_note">Pending note <a href="/notes/admin/?url=<?php echo $id ?>">Approve/Delete</a> +<div class="pending_note">Pending note +<a href="/notes/admin/?url=<?php echo $id ?>">Approve/Delete</a> +(<a href="/manual/en/<?php echo $id ?>">view origin</a>) <?php } else { ?> <div class="note"> <?php } ?>


 [2007-03-31 18:27 UTC] moosh (Christophe Gesché)
I hope that's usefull because it's my first patch submission
 [2007-03-31 18:52 UTC] wiesemann (Mark Wiesemann)
This was already fixed in bug #10514. Greg has corrected the SQL query => pending notes will only be shown on the right page after the next pearweb release. He also made the manual page that the note belongs to visible on /notes/admin/. @Christophe: You might want to use the new patch attachment feature next time, this will avoid the useless linebreaks that are added because of the line length limit here in the bug tracker.
 [2007-03-31 19:01 UTC] wiesemann (Mark Wiesemann)
Sorry, ignore my comment on the patch attachment. You already used it with the second comment ... (but this shows another bug BTW)
 [2007-04-01 21:59 UTC] davidc (David Coallier)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on by the end of next Sunday (CET). If this was a problem with the website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.