Description: ------------ The build of the header and the body is done in Structures_DataGrid_Renderer_XLS::getSpreadsheet(), I move it to the Structures_DataGrid_Renderer_XLS::render() - Added naming of worksheet (optionnal) - Possibility to modify the worksheet before rendering // $Id: XLS.php,v 1.23 2005/10/11 00:40:01 olivierg Exp $ Test script: --------------- /** * Force download the spreadsheet * * @access public */ function render() { $this->getSpreadsheet(); if (!$this->_rendered) { $dg->_setDefaultHeaders(); if ($this->header) { $this->_buildHeader(); } $this->_buildBody(); $this->_rendered = true; } $this->_workbook->close(); } /** * Get the spreadsheet object * * @access public */ function &getSpreadsheet($worksheetName = null) { if(!is_a($this->_workbook, "Spreadsheet_Excel_Writer")) { $dg =& $this->_dg; if ($this->_sendToBrowser) { $this->_workbook = new Spreadsheet_Excel_Writer(); $this->_workbook->send($this->_filename); } else { $this->_workbook = new Spreadsheet_Excel_Writer($this->_filename); } $this->_worksheet =& $this->_workbook->addWorksheet($worksheetName); } return $this->_workbook; }

This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. I have modified the XLS renderer to allow such customizations (among many others). You can now provide custom Excel Writer objects. Example : $workbook = new Spreadsheet_Excel_Writer(); $workbook->send('test.xls'); $worksheet =& $workbook->addWorksheet("My Worksheet"); $renderer =& $datagrid->getRenderer(); $renderer->setCustomWriter ($workbook, $worksheet); $datagrid->render();

Thanks, it's better like this :)