| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.0.0b4 |
| Bug #20929 | Breaks with PEAR 1.10.0dev2: Cannot make static method PEAR::isError() non stat | ||
|---|---|---|---|
| Submitted: | 2015-07-31 14:38 UTC | ||
| From: | cweiske | Assigned: | cweiske |
| Status: | Closed | Package: | HTTP_Upload (version 1.0.0b2) |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | (Not assigned) | ||
[2015-07-31 14:38 UTC] cweiske
(Christian Weiske)
Description:
------------
When uploading package files to pear.php.net, I get the following
error:
PHP Fatal error: Cannot make static method PEAR::isError() non
static in class HTTP_Upload_File in
/local/lib/php/HTTP/Upload.php on line 886, referer:
https://pear.php.net/release-upload.php
Comments
[2015-11-28 22:50 UTC] tyrael
(Ferenc Kovacs)
we just bumped into this on pecl.php.net as well.
for us we just added the missing public static to
/usr/share/php/HTTP/Upload.php
but I it would be nice having a new release for HTTP_Upload with the fix (we should also bump the php minversion to 5.4 for that release) and I just wonder how many other people could be affected by this(having a pear package with a subclass extending some method which was marked to static after the pear 1.10 release).
[2015-12-08 17:27 UTC] cweiske
(Christian Weiske)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: cweiske
Unfortunately this broke the method itself, which used $this.
BC break: I had to rename the method from isError() to hasError() to keep the functionality with PEAR 1.10.0.
This method was not used in pearweb at all, so we at least don't have a problem.