| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 3.7.2 |
| Bug #19859 | CodeSniffer::setIgnorePatterns API changed | ||
|---|---|---|---|
| Submitted: | 2013-03-16 19:47 UTC | ||
| From: | costelloc | Assigned: | squiz |
| Status: | Closed | Package: | PHP_CodeSniffer (version 1.4.4) |
| PHP Version: | 5.3.10 | OS: | linux |
| Roadmaps: | (Not assigned) | ||
[2013-03-16 19:47 UTC] costelloc
(Cash (Elgg))
Description:
------------
I have been using setIgnorePatterns() programmatically to set
ignore patterns (see test script code snippet).
This has recently broken. setIgnorePatterns() is a part of the API
as a public method. Backward compatibility could be added by
testing keys/values. Also the documentation needs to be updated
on setIgnorePatterns() to describe the array structure expected.
Test script:
---------------
$ignores = array('*/tests/*', '*/vendor/*');
$sniffer->setIgnorePatterns($ignores);
Comments
[2013-03-18 07:43 UTC] squiz
(Greg Sherwood)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: squiz
Thanks for letting me know. I committed backwards compatibility to the github repo:
https://github.com/squizlabs/PHP_CodeSniffer/commit/4982619b53bf7cea6255bc1dac
57b89096c046f4